chore(repo): use shell-emulator for better cross-platform compatibility.#1743
chore(repo): use shell-emulator for better cross-platform compatibility.#1743danielbayley wants to merge 2 commits intorollup:masterfrom
Conversation
danielbayley
requested review from
Andarist,
shellscape,
tada5hi and
tjenkinson
as code owners
danielbayley
force-pushed
the
shell-emulator
branch
from
142b54f to
2f47dfd
Compare
tada5hi
changed the title
|
failing wasm test should be unrelated to pr?! |
shellscape
changed the title
shellscape
left a comment
shellscape
left a comment
There was a problem hiding this comment.
@danielbayley I'm good to merge this once the conflicts are resolved. To resolve the pnpm-lock conflict, run pnpm i in the repo root and pnpm will take care of it for us.
danielbayley
force-pushed
the
shell-emulator
branch
from
2f47dfd to
7d4dee5
Compare
|
@shellscape Should be resolved now… |
|
Closing as abandoned. Please feel free to reopen if you get back around to it. |
I resolved the issue, as requested @shellscape 🤷🏻♂️ My other PR (#1744) is on hold only because/if #1782 is set to supercede it… But as already mentioned, this one should be good to go! @shellscape |
Bump @shellscape |
shellscape
changed the title
|
@danielbayley ugh. that stupid corepack bug has us blocked in our workflows. this is going to take me a couple of days to get to. |
@shellscape Yeah I think the same shit hit a bunch of my CI workflows! 🙈 I'm migrating them off corepack now, since it's set to be deprecated anyway… |
|
@danielbayley this one is quite old, but we've fixed up the repo since. if you update from upstream/main I think we'll be in good shape |
danielbayley
force-pushed
the
shell-emulator
branch
from
7d4dee5 to
6329045
Compare
@shellscape Ok cool. Rebased… |
3 participants
Rollup Plugin Name:
*This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
I started work on a separate PR, but quickly ran into errors with the
preparescriptsapparently not being cross-platform (ifcommand not found—I am on macOS). Since this is apnpmmonorepo, and thescriptsare very simple, why not make use of theshell-emulator.npmrcconfig option (which uses yarnpkg-shell)? This also means the dependency ondel-cliis no longer necessary.